Skip to content

fix(weave): support eval_results filtering on inputs#7006

Merged
domphan-wandb merged 1 commit into
masterfrom
dom/eval-filtering-on-io
Jun 18, 2026
Merged

fix(weave): support eval_results filtering on inputs#7006
domphan-wandb merged 1 commit into
masterfrom
dom/eval-filtering-on-io

Conversation

@domphan-wandb

@domphan-wandb domphan-wandb commented May 29, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes a few issues with filtering and sorting capabilities on imperatively logged evals because they don't have an actual dataset.

Background
Notion doc for more context: Supporting filtering on multiple evals

Frontend PRs that will use this new functionality:

  1. https://github.com/wandb/core/pull/44731
  2. https://github.com/wandb/core/pull/44732
  3. https://github.com/wandb/core/pull/44734

Problem

Filtering and sorting on inputs.* was returning empty results whose row_digest had no matching row in table_rows.

  • The query builder buildsresolved_inputs with COALESCE(tr.val_dump, JSONExtractRaw( inputs_dump, 'example'))
    • tr is the result of a LEFT JOIN on the row digest.
    • If the row digest is null, like in the case of imperatively logged evals, then Clickhouse fills the result with the default value, '', because val_dump is a non nullable string.

COALESCE will always return the empty string, which makes sorting and filtering broken on inputs.

To fix this, the PR adds nullIf calls on the val_dump so that the COALESCE can actually fallthrough to the example.

Testing

How was this PR tested?

  • Against dev frontend
  • unit tests updated

@domphan-wandb domphan-wandb requested a review from a team as a code owner May 29, 2026 00:26
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@domphan-wandb domphan-wandb force-pushed the dom/eval-filtering-on-io branch 2 times, most recently from e374861 to 0f9c76b Compare June 1, 2026 17:35
@domphan-wandb domphan-wandb force-pushed the dom/eval-filtering-on-io branch from 0f9c76b to 868c623 Compare June 5, 2026 20:14
@domphan-wandb domphan-wandb force-pushed the dom/eval-filtering-on-io branch from 868c623 to c669669 Compare June 8, 2026 16:16
@domphan-wandb domphan-wandb merged commit ad5227c into master Jun 18, 2026
341 of 343 checks passed
@domphan-wandb domphan-wandb deleted the dom/eval-filtering-on-io branch June 18, 2026 17:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants